Diff on target change #20
Conversation
|
I don't understand why the build on Travis failed. Could you help with that? |
|
Hey @diogomatsubara. Thanks for the PR and apologies for the delay. I'm just now ramping up to take another look at this project. The Travis failure was most likely caused by a change in the location of one of the dependencies. I saw the same failure on master locally when running I agree with your problem statement and like the suggestion of showing the differences. But I'm not completely in love with the readability of the diff as implemented in your PR. For instance, a simple I'd love to give some thought to improving the readability. More importantly, I would like to see code changes accompanied by tests that demonstrate and validate the new functionality. If you're still interested in this project, could you take a look at |
|
Over a year of this PR being open. Dagnabbit. |
from diogomatsubrata on [PR-20](guidowb#20) 2. I changed his code to redact tokens and secrets. A sha256 sum is used to show there are differences without exposing the actual values. 3. Changed the unified diff code to not be dependent on an archived read-only directoy.
… displaying a unified diff. (#4) * Using "github.com/go-corelibs/diff" diff package * private package for unified diff copied from https://github.com/golang/tools/tree/v0.24.0 * 1. Show an unified diff of what changed based upon the work from diogomatsubrata on [PR-20](guidowb#20) 2. I changed his code to redact tokens and secrets. A sha256 sum is used to show there are differences without exposing the actual values. 3. Changed the unified diff code to not be dependent on an archived read-only directoy. * Added new dependencies * go fmt cleanup * I could not figure out how to make a local module/package withou using a replace line. * 1. resolve <nil> printing after the diff 2. Make the code more idomatic go * Shorten up the required copyright notice * Only call unified diff printing if there are changes
* Using "github.com/go-corelibs/diff" diff package * private package for unified diff copied from https://github.com/golang/tools/tree/v0.24.0 * 1. Show an unified diff of what changed based upon the work from diogomatsubrata on [PR-20](guidowb#20) 2. I changed his code to redact tokens and secrets. A sha256 sum is used to show there are differences without exposing the actual values. 3. Changed the unified diff code to not be dependent on an archived read-only directoy. * Added new dependencies * go fmt cleanup * I could not figure out how to make a local module/package without using a replace line. * 1. resolve <nil> printing after the diff 2. Make the code more idomatic go * Shorten up the required copyright notice * Only call unified diff printing if there are changes * Added instal target for development building * 1. A bad version value does not cause a panic 2. Some docs to refresh the brain cells in the future * Bump version_tag (patch+1) to make Dennis happy * Fix error message to display the number of version parts * 1. handle case if there are no tags 2. make clean up less dangerous if we get nasty input * add some vscode ignore files
Hi, I wonder if you are interested in this change.
It shows an uniffied diff of the changes before each of the save commands. I found myself moving a lot between targets and never know if I should discard a change or save it. This helps me with that.
It's my first contribution to a go project, so please let me know how to get this into shape to merge into master.
Thank you!