Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3.0 branch #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

V3.0 branch #8

wants to merge 9 commits into from

Conversation

thrawn01
Copy link
Collaborator

@thrawn01 thrawn01 commented Apr 16, 2024 •
edited
Loading

Purpose

Prep Gubernator for a v3.0 release. This is a long running branch where we will merge V3 related feature once they are ready.

Removing GRPC Support

GRPC turned out to be more trouble than it was worth. Although GRPC has consistent semantics like flow control, request cancellation, and error handling, and decent performance. However, it is not without
its issues.

  • GRPC is more complex than is necessary for high-performance, distributed environments. Like Request Queuing, and built-in concurrency limits.
  • GRPC implementations can be slower than expected (Slower than standard HTTP in some cases)
  • Using GRPC can result in more code than using standard HTTP
  • GRPC is not suitable for the public facing web based APIs
  • GRPC has proxy and service mesh issues

Merged

TODO

See V3 Milestone -->

@thrawn01 thrawn01 self-assigned this Apr 16, 2024
@Baliedge Baliedge mentioned this pull request Apr 19, 2024
Closed
@thrawn01 thrawn01 force-pushed the v3.0 branch 4 times, most recently from 0bc64c9 to 5009e4b Compare April 24, 2024 00:41
@thrawn01 thrawn01 mentioned this pull request May 1, 2024
Merged
@thrawn01 thrawn01 force-pushed the v3.0 branch 3 times, most recently from e02ccf7 to bacf10c Compare May 20, 2024 21:32
@thrawn01
WIP: New V3.0 Release
6c14a4d
@thrawn01
Otter is now available as a cache option
95e51c4 
Fixed race condition in tokenBucket()

Fixed race conditions in leakybucket

Added Otter cost func, and reduced memory and time it takes to run the benchmarks

Fixed flapping cache eviction test

Added LRUMutexCache restored LRUCache
@thrawn01
Finished the otter merge into v3
9ae8c8a
@thrawn01
Fixed flapping TestLeakyBucketGregorian and nil error in asyncRequest()
df776be
@thrawn01
Improved validate make target
e905594
@thrawn01
Fixed TestHighContentionFromStore test
3bc4d4e
@thrawn01
Improving benchmark tests
dc9b528
@thrawn01 thrawn01 marked this pull request as ready for review June 11, 2024 20:54
@thrawn01 thrawn01 requested a review from Baliedge as a code owner June 11, 2024 20:54
@thrawn01 thrawn01 changed the title WIP: Remove GRPC and create a new V3.0 branch Remove GRPC and create a new V3.0 branch Jun 11, 2024
@thrawn01 thrawn01 changed the title Remove GRPC and create a new V3.0 branch V3.0 branch Jun 12, 2024
@thrawn01 thrawn01 added this to the V3 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baliedge Baliedge Awaiting requested review from Baliedge Baliedge is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@thrawn01 thrawn01

Labels
None yet
Projects
None yet
Milestone
V3
Development

Successfully merging this pull request may close these issues.
1 participant
@thrawn01