Adds temporary workaround for mink-selenium-driver #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfodeke
requested review from
shrop,
joestewart,
bdone,
mikebarkas and
catapipper
joestewart
requested changes
Sep 5, 2019
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.6", | |||
| "behat/mink-selenium2-driver": "dev-master as 1.3.x-dev", | |||
There was a problem hiding this comment.
I believe this should be in the "require-dev" section.
There was a problem hiding this comment.
I can move it, but from what I see in drupal-composer/drupal-project#511 (comment) has it in the require section.
Still move it?
There was a problem hiding this comment.
Yes I think so since it is a dev dependency in the first place.
minkphp/MinkSelenium2Driver#313 (comment)
I used "1.4.x-dev as 1.3.x-dev" locally to be able to work on a project.
There was a problem hiding this comment.
This PR shouldn't be required now - https://packagist.org/packages/behat/mink-selenium2-driver#1.3.x-dev
|
Just tested and builds are now passing so closing this one. Thanks for the help on this @bfodeke and @joestewart ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: drupal-composer/drupal-project#511 (comment)