Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Ids #5

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Log Ids #5

merged 1 commit into from
Jun 18, 2024

Conversation

CalebCourier
Copy link
Collaborator

Adds ids to Call, Iteration, and ValidationOutcome

@CalebCourier CalebCourier requested review from zsimjee, nichwch, wylansford and a team June 17, 2024 20:38
Copy link

@nichwch nichwch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this automatically set the id to the object ID of the call/iteration? I don't see the logic for doing that in this PR, unless you plan to do that in a separate PR

@CalebCourier
Copy link
Collaborator Author

Does this automatically set the id to the object ID of the call/iteration? I don't see the logic for doing that in this PR, unless you plan to do that in a separate PR

That will happen once this is implemented in the open source; can probably put up a PR for that first thing tomorrow morning.

@CalebCourier CalebCourier merged commit 348b49c into main Jun 18, 2024
1 check passed
@CalebCourier CalebCourier deleted the log-ids branch June 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants