Fix TOCTOU in create_dirs_impl #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the check whether a directory exists before trying to create it with handling for already-exists cases. This addresses a race where the directory is created by another process, leading to a failure. Signed-off-by: Itay Bookstein <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 88.16% 87.80% -0.36%
==========================================
Files 4 4
Lines 566 566
==========================================
- Hits 499 497 -2
- Misses 67 69 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the check whether a directory exists before trying to
create it with handling for already-exists cases. This addresses
a race where the directory is created by another process, leading
to a failure.
This happened when multiple processes were started up simultaneously with configurations that lead to the creation of the same parent directory.