Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use external spdlog library #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optionally use external spdlog library #72

wants to merge 2 commits into from

Conversation

swltr
Copy link

@swltr swltr commented Jan 5, 2021

As mentioned in #7, it would be nice to allow external dependencies to be used.
This helps e.g. if you already have spdlog as a dependency in your CMake build.
With this small change, it is possible to turn off auto-detecting spdlog.
Leaving the target_link_libraries(spdlog_setup ...) calls as they are, these then simply use an existing spdlog library.
You need to add that library somewhere else in your build, then.
In my case, I have a line like

add_subdirectory(libs/cmake/spdlog-1.3.1)

in my top-level CMakeLists.txt.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #72 (7d0a773) into master (91ecd72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files           4        4           
  Lines         566      566           
=======================================
  Hits          499      499           
  Misses         67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ecd72...7d0a773. Read the comment docs.

@swltr
Copy link
Author

swltr commented Jan 5, 2021

@guangie88 What do you think about this?

@swltr
Copy link
Author

swltr commented Mar 2, 2021

@guangie88 Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant