Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: Include ashpd only on linux so that listings run on macos #1867

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

daxhuiberts
Copy link
Contributor

This will make ashpd only a dependency on linux.

An alternative would be something like cfg(all(unix, not(target_os = "macos"))) to still include it for all other unix family.

@bilelmoussaoui
Copy link
Member

The code using it should also be behind a similar guard

@daxhuiberts
Copy link
Contributor Author

The code using it should also be behind a similar guard

I looked into disabling the main_event_loop_7 bin, but there currently is no simple way to achieve that (see rust-lang/cargo#9208)
Not sure what the appropriate approach would be in this case.

@daxhuiberts
Copy link
Contributor Author

I made a change to main_event_loop_7 with a possible solution, but this approach is probably not desirable.

@bilelmoussaoui
Copy link
Member

Also, please fix the formatting, otherwise the suggested solution is the best we can do so it is fine.

@daxhuiberts
Copy link
Contributor Author

Thanks for the feedback.
Fixed the newline and formatting.

@bilelmoussaoui bilelmoussaoui merged commit b7f4575 into gtk-rs:master Oct 17, 2024
2 of 3 checks passed
@bilelmoussaoui
Copy link
Member

Thanks!

@daxhuiberts daxhuiberts deleted the include-ashpd-only-on-linux branch October 18, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants