Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: Stop renaming ffi crate #1569

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

bilelmoussaoui
Copy link
Member

As we would like to define those crates in the main workspace file to simplify the release process

Needs a gtk4-rs/gtk-rs-core regen first, to ensure everything is still working as expected.

Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me once you made it work for gtk-rs-core/gtk4-rs/gstreamer-rs and there are no bad surprises :)

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/stop-renaming-ffi branch from 9a2a385 to 3b19fa4 Compare June 1, 2024 08:28
As we would like to define those crates in the main workspace file
to simplify the release process
@bilelmoussaoui bilelmoussaoui merged commit 6a8847c into master Jun 1, 2024
7 checks passed
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/stop-renaming-ffi branch June 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants