-
-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #211 from grunwaldlab/cran-maintenance-2.8.4
Update unique.MLG documentation for CRAN
- Loading branch information
Showing
236 changed files
with
4,924 additions
and
3,235 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,3 +19,4 @@ | |
^CONTRIBUTING.md$ | ||
^_pkgdown\.yml$ | ||
^appveyor\.yml$ | ||
^pkgdown$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
This package was submitted to CRAN on 2019-06-14. | ||
Once it is accepted, delete this file and tag the release (commit a2b31fd4d3). | ||
This package was submitted to CRAN on 2020-02-12. | ||
Once it is accepted, delete this file and tag the release (commit d7ae8d2f4e). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
Package: poppr | ||
Type: Package | ||
Title: Genetic Analysis of Populations with Mixed Reproduction | ||
Version: 2.8.3 | ||
Date: 2019-06-13 | ||
Version: 2.8.4 | ||
Authors@R: c(person(c("Zhian", "N."), "Kamvar", role = c("cre", "aut"), | ||
email = "[email protected]", comment = c(ORCID = "0000-0003-1458-7108")), | ||
person(c("Javier", "F."), "Tabima", role = "aut", | ||
|
@@ -66,4 +65,4 @@ Suggests: | |
RClone | ||
License: GPL-2 | GPL-3 | ||
VignetteBuilder: knitr | ||
RoxygenNote: 6.1.1 | ||
RoxygenNote: 7.0.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,62 +1,23 @@ | ||
# Poppr version 2.8.3 | ||
# Poppr version 2.8.4 | ||
|
||
This is an attempt at fixing a LaTeX issue with a straddling link [0] | ||
This is a fix for a warning on CRAN: | ||
|
||
[0]: https://hypatia.math.ethz.ch/pipermail/r-package-devel/2019q2/004093.html | ||
On Wed, Feb 12, 2020 at 6:20 AM Kurt Hornik <[email protected]> wrote: | ||
Dear maintainer, | ||
|
||
Please see the problems shown on | ||
<https://cran.r-project.org/web/checks/check_results_poppr.html>. | ||
|
||
Thank you for implementing the extra checks for poppr. I really | ||
appreciate the hard work that goes into maintenance of CRAN. Because | ||
of the extra checks, I was able to find old code that was poorly | ||
written and subsequently was fixed. | ||
Please correct before 2020-02-26 to safely retain your package on CRAN. | ||
|
||
This resubmission addresses the following concerns: | ||
|
||
> If there are references describing the methods in your package, please | ||
> add these in the Description field of your DESCRIPTION file in the form | ||
> authors (year) doi:... | ||
> authors (year) arXiv:... | ||
> authors (year, ISBN:...) | ||
> with no space after 'doi:', 'arXiv:' and angle brackets for auto-linking. | ||
Done. | ||
|
||
> Please do not modify the global environment (e.g. by using <<-) in your | ||
> functions. | ||
Done. There is currently one function that still contains this, but it is | ||
properly scoped and does not modify the global environment. | ||
|
||
> Please always reset the user's options, working directory, ... in your | ||
> examples (e.g. man/getfile.Rd). | ||
Done. | ||
|
||
> Please ensure that your functions do not write by default or in your | ||
> examples/vignettes/tests in the user's home filespace. That is not allow | ||
> by CRAN policies. Please only write/save files if the user has specified | ||
> a directory. In your examples/vignettes/tests you can write to tempdir() | ||
Done. | ||
|
||
> Please replace \dontrun{} by \donttest{} or if(interactive()){} in your | ||
> Rd-file. | ||
I have not done this and am hesitant to do so as several of the examples that | ||
use \dontrun will have long-running code to show more in-depth examples or have | ||
code that will fail to show more realistic scenarios for user file interactions. | ||
Because of the long-running examples, I fear that wrapping them in \donttest | ||
would cause my package to fail because of their runtime. | ||
|
||
I do realize I could wrap these in if (interactive()), but then I would not be | ||
able to illustrate the longer-running examples on my documentation website | ||
(i.e. https://grunwaldlab.github.io/poppr/reference/bitwise.dist.html#examples) | ||
Best, | ||
-k | ||
|
||
## Test environments | ||
|
||
* local macOS install, R 3.6.0 | ||
* local ubuntu 16.04 install, R 3.6.0 | ||
* ubuntu 14.04 (on travis-ci), devel (2019-06-17 r76705) and R 3.6.0 | ||
* local macOS install, R 3.6.2 | ||
* local ubuntu 16.04 install, R 3.6.2 | ||
* ubuntu 14.04 (on travis-ci), devel (2019-06-17 r76705) and R 3.6.2 | ||
* windows R Under development (unstable) | ||
|
||
## R CMD check results | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.