Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
zkamvar committed Aug 28, 2016
1 parent a5f41ec commit ad67079
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Poppr version 2

In development:
[![Build Status](https://travis-ci.org/grunwaldlab/poppr.svg?branch=latex-fix)](https://travis-ci.org/grunwaldlab/poppr)
[![Coverage Status](https://coveralls.io/repos/grunwaldlab/poppr/badge.svg?branch=latex-fix)](https://coveralls.io/r/grunwaldlab/poppr?branch=latex-fix)
[![Build Status](https://travis-ci.org/grunwaldlab/poppr.svg?branch=master)](https://travis-ci.org/grunwaldlab/poppr)
[![Coverage Status](https://coveralls.io/repos/grunwaldlab/poppr/badge.svg?branch=master)](https://coveralls.io/r/grunwaldlab/poppr?branch=master)

On CRAN:
[![Downloads from Rstudio mirror per month](http://cranlogs.r-pkg.org/badges/poppr)](http://www.r-pkg.org/pkg/poppr)
Expand Down
30 changes: 27 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## Test environments

* local OS X install, R 3.3.0
* ubuntu 12.04 (on travis-ci), devel [2016-06-08 r70734] and R 3.3.0
* win-builder (devel [2016-06-08 r70728])
* local OS X install, R 3.3.1
* ubuntu 12.04 (on travis-ci), devel [2016-08-28 r71162] and R 3.3.1
* win-builder (devel [2016-08-27 r71160])

## R CMD check results

Expand All @@ -21,6 +21,30 @@ Found the following (possibly) invalid URLs:

This is indeed a valid URL

## valgrind

There is currently a valgrind note on CRAN. It was brought up on 2016-06-08.
I responded on 2016-06-09:

> It was my understanding that this was an artifact due to the behavior of
> OpenMP and valgrind (possibly summarized in a similar situation here:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36298), which is why the leak
> summary does not show any memory that is definitely or indirectly lost.
>
> FWIW, the summary points to line 255 in the code, which is in the middle of an
> OMP pragma statement:
> https://github.com/grunwaldlab/poppr/blob/fda8606ab9c9965
> 42cabc8c9092e024ceb86e4cd/src/bitwise_distance.c#L254-L259
Kurt's response on 2016-06-13:

> Right. So there's perhaps nothing you can do about this.
>
> On its way to CRAN ...
>
> Best
> -k
## Downstream dependencies

- popprxl: OK
Expand Down

0 comments on commit ad67079

Please sign in to comment.