Skip to content

Commit

Permalink
submit version 2.4.1 to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
zkamvar committed Apr 13, 2017
1 parent 3958a45 commit 71ebe06
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 6 deletions.
27 changes: 22 additions & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,36 @@

This is a resubmission.

I previously submitted a day ago and subsequently found a silent user-facing bug
that impacts users negatively. This update fixes that bug.
This submission fixes two bugs:

- Parallel code that threw an error on Fedora systems was serialized
(https://github.com/grunwaldlab/poppr/issues/138)
- A significant and silent user-facing bug was fixed
(https://github.com/grunwaldlab/poppr/issues/136)

## Test environments

* local OS X install, R 3.3.3
* ubuntu 12.04 (on travis-ci), devel (2017-04-07 r72495) and R 3.3.3
* winbuilder R version 3.4.0 beta (2017-04-07 r72496)
* ubuntu 12.04 (on travis-ci), devel (2017-04-12 r72509) and R 3.3.3
* winbuilder R version 3.4.0 beta (2017-04-12 r72509)
* Rhub fedora-gcc-devel (2017-04-08 r72499)

## R CMD check results

All good on the above platforms.
On winbuilder:
>
> * checking CRAN incoming feasibility ... NOTE
> Maintainer: 'Zhian N. Kamvar <[email protected]>'
>
> Days since last update: 3
I have been in communication with Professor Ligges about this update.

## Solaris SPARC

There is currently an ERROR on poppr's results, but this originates in another
package. I have submitted code to fix this:
https://github.com/thibautjombart/adegenet/pull/176

## valgrind

Expand Down
3 changes: 2 additions & 1 deletion man/is.clone.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 71ebe06

Please sign in to comment.