Generated reflection service code #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In order to develop the Reflection Service, the specific proto file should be included in the module and the service code generated from it. Modifications: Created the module for the Reflection Service, added the proto file, updated the Package.swift to include the module, updated the Makefile to inlude targets for generating the server code, created the ReflectionProvider. Result: The Reflection Service can now be implemented.
glbrntt
reviewed
Oct 3, 2023
Package.swift
Outdated
| @@ -89,6 +89,7 @@ extension Target.Dependency { | |||
| static let interopTestModels: Self = .target(name: "GRPCInteroperabilityTestModels") | |||
| static let interopTestImplementation: Self = | |||
| .target(name: "GRPCInteroperabilityTestsImplementation") | |||
| static let reflectionService: Self = .target(name: "ReflectionService") | |||
There was a problem hiding this comment.
Suggested change
| static let reflectionService: Self = .target(name: "ReflectionService") | |
| static let reflectionService: Self = .target(name: "GRPCReflectionService") |
Package.swift
Outdated
| @@ -428,6 +429,19 @@ extension Target { | |||
| "README.md", | |||
| ] | |||
| ) | |||
|
|
|||
| static let reflectionService: Target = .target( | |||
| name: "ReflectionService", | |||
There was a problem hiding this comment.
Suggested change
| name: "ReflectionService", | |
| name: "GRPCReflectionService", |
| @@ -0,0 +1,141 @@ | |||
| // Copyright 2023 The gRPC Authors | |||
There was a problem hiding this comment.
This license header should be unchanged from https://github.com/grpc/grpc-proto/blob/master/grpc/reflection/v1/reflection.proto
| @@ -0,0 +1,29 @@ | |||
| /* | |||
| * Copyright 2019, gRPC Authors All rights reserved. | |||
| import GRPC | ||
|
|
||
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | ||
| final class ReflectionProvider: Reflection_ServerReflectionAsyncProvider { |
There was a problem hiding this comment.
Suggested change
| final class ReflectionProvider: Reflection_ServerReflectionAsyncProvider { | |
| final class ReflectionService: Reflection_ServerReflectionAsyncProvider { |
Comment on lines
23
to
25
| requestStream: GRPC.GRPCAsyncRequestStream<Reflection_ServerReflectionRequest>, | ||
| responseStream: GRPC.GRPCAsyncResponseStreamWriter<Reflection_ServerReflectionResponse>, | ||
| context: GRPC.GRPCAsyncServerCallContext |
There was a problem hiding this comment.
Suggested change
| requestStream: GRPC.GRPCAsyncRequestStream<Reflection_ServerReflectionRequest>, | |
| responseStream: GRPC.GRPCAsyncResponseStreamWriter<Reflection_ServerReflectionResponse>, | |
| context: GRPC.GRPCAsyncServerCallContext | |
| requestStream: GRPCAsyncRequestStream<Reflection_ServerReflectionRequest>, | |
| responseStream: GRPCAsyncResponseStreamWriter<Reflection_ServerReflectionResponse>, | |
| context: GRPCAsyncServerCallContext |
glbrntt
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In order to develop the Reflection Service, the specific proto file should be included in the module and the service code generated from it.
Modifications:
Created the module for the Reflection Service, added the proto file, updated the Package.swift to include the module, updated the Makefile to inlude targets for generating the server code, created the ReflectionProvider.
Result:
The Reflection Service can now be implemented.