Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server connection management tests to swift-testing #14

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Oct 15, 2024

Motivation:

I'd like to add more tests to the server connection management handler. Ideally these would be written using swift-testing.

Modifications:

  • Migrate server connection management handler tests
  • Use package access to avoid @testable import

Result:

Fewer XCTest tests

Motivation:

I'd like to add more tests to the server connection management handler.
Ideally these would be written using swift-testing.

Modifications:

- Migrate server connection management handler tests
- Use `package` access to avoid `@testable` import

Result:

Fewer XCTest tests
@glbrntt glbrntt requested a review from gjcairo October 15, 2024 11:09
@glbrntt glbrntt added the semver/patch No public API change. label Oct 15, 2024
@glbrntt glbrntt enabled auto-merge (squash) October 15, 2024 11:10
@glbrntt glbrntt merged commit bed03b0 into grpc:main Oct 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants