Skip to content

Commit

Permalink
Remove '@_exported import GRPCCore' (#25)
Browse files Browse the repository at this point in the history
Motivation:

We added '@_exported import GRPCCore' to transport modules to make it
easier for users as it saves them from adding an import. On reflection
we've our position on this has changed and the implicit dependency will
likely make things less clear.

Modifications:

- Remove exported import of GRPCCore

Result:

More explicit dependencies
  • Loading branch information
glbrntt authored Nov 8, 2024
1 parent 058c8ca commit a2e1ea8
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ let targets: [Target] = [
name: "GRPCNIOTransportHTTP2Tests",
dependencies: [
.target(name: "GRPCNIOTransportHTTP2"),
.product(name: "GRPCCore", package: "grpc-swift"),
.product(name: "X509", package: "swift-certificates"),
.product(name: "NIOSSL", package: "swift-nio-ssl"),
],
Expand Down
1 change: 0 additions & 1 deletion Sources/GRPCNIOTransportHTTP2/Exports.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* limitations under the License.
*/

@_exported import GRPCCore
@_exported import GRPCNIOTransportCore
@_exported import GRPCNIOTransportHTTP2Posix
@_exported import GRPCNIOTransportHTTP2TransportServices
1 change: 0 additions & 1 deletion Sources/GRPCNIOTransportHTTP2Posix/Exports.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@
* limitations under the License.
*/

@_exported import GRPCCore
@_exported import GRPCNIOTransportCore
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@
* limitations under the License.
*/

@_exported import GRPCCore
@_exported import GRPCNIOTransportCore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import Crypto
import Foundation
import GRPCCore
import GRPCNIOTransportHTTP2Posix
import NIOSSL
import SwiftASN1
Expand Down

0 comments on commit a2e1ea8

Please sign in to comment.