Migrate CI to use swiftlang / SwiftNIO common GitHub Actions. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Nov 6, 2024
| @@ -0,0 +1,37 @@ | |||
| name: Soundness | |||
There was a problem hiding this comment.
Can we inline this in pull_request.yml?
There was a problem hiding this comment.
We can but then it won't display as PR / Soundness / Swift license headers check (pull_request) as the other soundness and license header checks do, that's the reason for the split-out.
There was a problem hiding this comment.
I think PR / Swift license headers check (pull_request)
There was a problem hiding this comment.
I thought grouping the like-checks was nice. So that both license header checks appeared in the same part of the hierarchy and are grouped if you look at the Checks tab.
rnro
force-pushed
the
adopt_standardized_github_actions
branch
8 times, most recently
from
8c94dde
to
f84c920
Compare
Motivation: * Reduce duplication * Centralise boilerplate changes when new Swift versions are picked up. * Benefit from centralised work to add new linting / test infrastructure. Modifications: Changes of note: * Use soundness checks from swiftlang/github-workflows. * Retain bespoke license-checking code for .swift files as the gRPC header style is very different to most templates. Result: More test, linting, formatting coverage. More common CI with other Swift on Server projects.
rnro
force-pushed
the
adopt_standardized_github_actions
branch
from
f84c920
to
3d5c28a
Compare
rnro
force-pushed
the
adopt_standardized_github_actions
branch
from
82e097e
to
bc39a3e
Compare
glbrntt
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Changes of note:
Result:
More test, linting, formatting coverage. More common CI with other Swift on Server projects.