Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on grpc-swift/main #8

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Depend on grpc-swift/main #8

merged 1 commit into from
Oct 15, 2024

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Oct 15, 2024

Motivation

We should depend on grpc-swift/main for now to make sure that everything works cross-package.

Modifications

This PR changes grpc-swift-extras to depend on main for grpc-swift. It also fixes some tests as a result of adding the cancellation handler to the API.

Result

grpc-swift-extras builds with the latest grpc-swift changes.

@gjcairo gjcairo added the semver/none No version change required. label Oct 15, 2024
@gjcairo gjcairo requested a review from glbrntt October 15, 2024 11:47
@glbrntt glbrntt merged commit f5b87e7 into grpc:main Oct 15, 2024
3 of 4 checks passed
@gjcairo gjcairo deleted the core-main branch October 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version change required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt