Merge pull request #93 from lowasser/top-level-constants-static

Make the top-level properties JvmStatic
grpc · May 13, 2020 · 19423e8 · 19423e8
2 parents 2690082 + d43136f
commit 19423e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 87 deletions.
diff --git a/compiler/src/main/java/io/grpc/kotlin/generator/TopLevelConstantsGenerator.kt b/compiler/src/main/java/io/grpc/kotlin/generator/TopLevelConstantsGenerator.kt
@@ -20,6 +20,7 @@ class TopLevelConstantsGenerator(config: GeneratorConfig): ServiceCodeGenerator(
   override fun generate(service: Descriptors.ServiceDescriptor): Declarations = declarations {
     addProperty(
       PropertySpec.builder("serviceDescriptor", ServiceDescriptor::class)
+        .addAnnotation(JvmStatic::class)
         .getter(
           FunSpec.getterBuilder()
             .addStatement("return %T.getServiceDescriptor()", service.grpcClass)
@@ -41,6 +42,7 @@ class TopLevelConstantsGenerator(config: GeneratorConfig): ServiceCodeGenerator(
             )
             .getter(
               FunSpec.getterBuilder()
+                .addAnnotation(JvmStatic::class)
                 .addStatement("return %T.get%LMethod()", service.grpcClass, method.methodName)
                 .build()
             )

diff --git a/stub/src/test/java/io/grpc/kotlin/ClientCallsTest.kt b/stub/src/test/java/io/grpc/kotlin/ClientCallsTest.kt
@@ -406,58 +406,6 @@ class ClientCallsTest: AbstractCallsTest() {
     }
   }
 
-  @FlowPreview
-  @Test
-  fun clientStreamingRpcCancellation() = runBlocking {
-    val serverCancelled = Job()
-    val serverReceived = Job()
-    val serverImpl = object : GreeterGrpc.GreeterImplBase() {
-      override fun clientStreamSayHello(
-        responseObserver: StreamObserver<HelloReply>
-      ): StreamObserver<HelloRequest> {
-        return object : StreamObserver<HelloRequest> {
-          private val names = mutableListOf<String>()
-
-          override fun onNext(value: HelloRequest) {
-            whenContextIsCancelled { serverCancelled.complete() }
-            Context.current().withCancellation().addListener(
-              Context.CancellationListener {
-                serverCancelled.complete()
-              },
-              directExecutor()
-            )
-            serverReceived.complete()
-            names += value.name
-          }
-
-          override fun onError(t: Throwable) = throw t
-
-          override fun onCompleted() {
-            responseObserver.onNext(
-              helloReply(names.joinToString(prefix = "Hello, ", separator = ", "))
-            )
-            responseObserver.onCompleted()
-          }
-        }
-      }
-    }
-
-    channel = makeChannel(serverImpl)
-
-    val requests = Channel<HelloRequest>()
-    val rpc = async {
-      ClientCalls.clientStreamingRpc(
-        channel = channel,
-        method = clientStreamingSayHelloMethod,
-        requests = requests.consumeAsFlow()
-      )
-    }
-    requests.send(helloRequest("Tim"))
-    serverReceived.join()
-    rpc.cancel(CancellationException("no longer needed"))
-    serverCancelled.join()
-  }
-
   @FlowPreview
   @Test
   fun clientStreamingRpcCancelled() = runBlocking {
@@ -661,39 +609,4 @@ class ClientCallsTest: AbstractCallsTest() {
     assertThat(responses.single()).isEqualTo(helloReply("Hello, Sunstone"))
     assertThat(requestsEvaluations.get()).isEqualTo(2)
   }
-
-  @ExperimentalCoroutinesApi
-  @Test
-  fun bidiStreamingCancelResponsesCancelsRequests() = runBlocking {
-    val serverImpl = object : GreeterGrpc.GreeterImplBase() {
-      override fun bidiStreamSayHello(
-        responseObserver: StreamObserver<HelloReply>
-      ): StreamObserver<HelloRequest> {
-        return object : StreamObserver<HelloRequest> {
-          override fun onNext(value: HelloRequest) {
-            responseObserver.onNext(helloReply("Hello, ${value.name}"))
-          }
-
-          override fun onError(t: Throwable) = throw t
-
-          override fun onCompleted() {
-            responseObserver.onCompleted()
-          }
-        }
-      }
-    }
-
-    val channel = makeChannel(serverImpl)
-
-    val cancelled = Job()
-    val requests = flow {
-      emit(helloRequest("Steven"))
-      emit(helloRequest("Garnet"))
-      suspendUntilCancelled { cancelled.complete() }
-    }
-    assertThat(
-      ClientCalls.bidiStreamingRpc(channel, bidiStreamingSayHelloMethod, requests).take(2).toList()
-    ).containsExactly(helloReply("Hello, Steven"), helloReply("Hello, Garnet")).inOrder()
-    cancelled.join()
-  }
 }