-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add unit test for channel state waiting for first resolver update #7768
Open
janardhanvissa
wants to merge
14
commits into
grpc:master
Choose a base branch
from
janardhanvissa:statechannel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
49329cf
Add unit test for channel state waiting for first resolver update
janardhankrishna-sai f314b62
removing space
janardhankrishna-sai 6ad9713
Moving TODO comments
janardhankrishna-sai 7d8ed8f
Used t.Skip instead with a message and used channel and goroutine
janardhankrishna-sai b74dcd2
removing comment
janardhankrishna-sai 2061c46
Moving t.Skip to up and updated AwaitState, shortCtx to ctx
janardhankrishna-sai f3c6931
Moving t.Skip to up and updated AwaitState, shortCtx to ctx
janardhankrishna-sai 7829dd6
Moving Idle before cc.Connect() and connectivity.Connecting after cc.…
janardhankrishna-sai 69c8a63
Adding time.Sleep
janardhankrishna-sai 3b33b19
removed the updateState and Ready after Connecting and updated message
janardhankrishna-sai a6d2b49
adding new test case with rpc call and adding awaitnostatechannel con…
janardhankrishna-sai 9a85a50
updating the comment
janardhankrishna-sai bc03ad2
updating the comment
janardhankrishna-sai cd4f22e
Updating skip msg and moving Idle connectivity before context
janardhankrishna-sai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this and why?
I think we have a bug, which this test doesn't actually appear to be testing, but which is described in the issue that asked for this test. IF there is a bug, we need to always skip the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have a bug that's why we added this test to skip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janardhanvissa you can skip the test unconditionally, i.e. remote the
if testing.Short()
. Also add more details in the skip message.