Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin and dependency #1113

Closed
wants to merge 4 commits into from
Closed

Update plugin and dependency #1113

wants to merge 4 commits into from

Conversation

pnoker
Copy link

@pnoker pnoker commented May 16, 2024

  • fix(deps): update dependency com.google.protobuf:protobuf-bom to v4
  • fix(deps): update dependency com.google.guava:guava-bom to v33.2.0-jre
  • chore(deps): update plugin org.jetbrains.kotlin.jvm to v1.9.24
  • chore(deps): update plugin io.spring.dependency-management to v1.1.5

@ST-DDT
Copy link
Collaborator

ST-DDT commented May 16, 2024

Hi @pnoker,
Could you please explain why you created a PR that merges the existing dependency PRs?

Have you tested the changes?

@pnoker
Copy link
Author

pnoker commented May 17, 2024

Hi @pnoker,

Could you please explain why you created a PR that merges the existing dependency PRs?

Have you tested the changes?

I am very sorry for the trouble I have brought to you. I have not tested enough. You can close this pr

@ST-DDT
Copy link
Collaborator

ST-DDT commented May 17, 2024

No problem. Have a nice weekend.

@ST-DDT ST-DDT closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnoker @ST-DDT