-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly indicates the release of context resources in retry middleware #279
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test for this behaviour?
@johanbrandhorst PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this a bit more, these manual cancel invocations are dangerous because if we add another error case we may forget to cancel. Could you refactor this function so that we can just defer cancel?
Also could you add some tests?
OK, I'll do it 👍 |
Hi @osamingo! Any progress? If not, I am happy to take over the changes requested 😄 |
@yashrsharma44 Thank you for mentioning me. |
Resolve #203