Switch to use libuvc upstream by default #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey KeKiefer, is this still interesting? I'm using this repo and have also extended it (but had not the time right now to do a merge request). If this is still of interest I could have a look on it and test it. Let me know. Edit: |
|
I totally forgot that I never merged this. I would definitely appreciate more eyes on this. It should be applicable to any platform, to some extent (we wouldn't be loading the right shared library with the python code, but that could be remedied). I would imagine it should work better with Windows as upstream libuvc is far ahead of our stale fork. I'd be curious to hear about your experiences on this platform. |
Launching the application multiple times will attempt to open multiple purethermal cameras, if they are available.
Commit libuvc/libuvc@53e2d2f added a value to the middle of the types enumeration, which broke our bindings. This manifested as the "uvc_start_streaming failed: -2" error. This change corrects the enumeration value to match master. Refs #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to upstream libuvc instead of the old groupgets fork solves a lot of problems. I'd like to merge these changes into master to do this by default, but would appreciate input from anyone using this repository.