-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timePicker minutes always set to current time #893
Conversation
Thanks for the fix! Could you elaborate here (or even better add a comment) as to why this fixes the issue? Maybe a link to the timePicker Android docs? Please also squash your commits into one for them to be merged. |
There was a strange bug, with using this code because it was only a reference to a variable that is reset when changing either hour or minute:
So I replaced this part and cared about deprecated methods, see : https://developer.android.com/reference/android/widget/TimePicker#setCurrentHour(java.lang.Integer) |
Hum sorry I still don't get it. Is it a known issue with the deprecated |
Sorry if I wasn't clear. There are 2 diffirent issues here:
|
99c625e
to
d743d23
Compare
Ah, now I got it - I looked at the surrounding code and found the
Thanks for that too. |
This PR fixes issue #890.