-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented -bhess option in xtb thermo submodule #1004
Conversation
Signed-off-by: Johannes Gorges <[email protected]>
Why do we need |
The xtb thermo module can save you the computation time to recompute the hessian. At the moment, xtb thermo gives wrong thermostatistical contributions if it is used for the hessian of an SPH calculation. |
src/prog/thermo.f90
Outdated
alp1=1.27_wp | ||
alp2=1.5d-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid using fixed float point numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is the whole function "copied" from the bhess
workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just "copied" the function from the bhess workflow. Otherwise the bhess subroutine has to be also rewritten to avoid this "double code".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you highlight which lines of code from src/hessian.f90
are actually relevant and could be "recycled" here? So that we can think about putting these parts of the code into single functions that could be reused in this project. I'd strongly speak against implementing doubled code using fixed float point parameters (which is in itself already a bit of bad practice), if we can avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it is mainly lines 397-416 from the updated hessian.F90 that could be reused here fairly easily.
Signed-off-by: Johannes Gorges <[email protected]>
Signed-off-by: Johannes Gorges <[email protected]>
Co-authored-by: Marcel Mueller <[email protected]>
Co-authored-by: Marcel Mueller <[email protected]>
Co-authored-by: Marcel Mueller <[email protected]>
Signed-off-by: Johannes Gorges <[email protected]>
Signed-off-by: Johannes Gorges <[email protected]>
Frequencies of the hessian file need to be scaled to remove the frequency shift caused by the bias RMSD potential. With the --bhess flag, xtb thermo now reads in an hessian_sph file from a previous xTB SPH calculation and scales the frequencies accordingly to reproduce the thermo contributions of the xTB SPH calculation.