Validate name uniqueness, but be aware of revision context #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had added a unique validation for MP and Variant names. Unfortunately, this broke validation when proposing revisions, as the way we validate those is to
newup a copy with the revisions applied and run the validations.This would always result in a duplicate name failure, so we had to back off the validation for that case as a temporary fix.
This introduces a more permanent fix. All
Moderatedentities now have anin_revision_validation_context. This will be set totruewhen the object is the result of a revision proposal and validations can take that into account in their logic.As a result, the name validation can function appropriately.
closes #863