Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fusion bugfixes and improvements #1125

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Various fusion bugfixes and improvements #1125

merged 8 commits into from
Oct 17, 2024

Conversation

susannasiebert
Copy link
Contributor

@susannasiebert susannasiebert commented Oct 9, 2024

  • Remove . between e and number in exon-specific fusion variant names. In order for this to take effect for existing fusions, we'll need to run something like Variants::FusionVariant.all.map{|v| v.name = v.generate_name; v.save} in the console after deploy
  • Fusion MP name should be Feature name plus Variant name
  • Fix bug in exon fusion coordinate background job - we'll need to rerun this background job for existing exon-specific fusion variants after backfilling the bookend exon coordinate transcript, build, and ensembl version (ETA: after be8ecc3 a backfill shouldn't be necessary anymore)
  • Add VICC compliant name to variant popovers and variant cards

@susannasiebert susannasiebert added the bugfix PR Label for bug fixes. Will appear in release notes. label Oct 9, 2024
@acoffman acoffman merged commit 18e4430 into main Oct 17, 2024
4 checks passed
@acoffman acoffman deleted the fusion_bugfixes branch October 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR Label for bug fixes. Will appear in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants