fixes minor UI issues discovered during v18 upgrades #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcmichael
added
the
bugfix
acoffman
approved these changes
Aug 15, 2024
| @@ -242,7 +240,7 @@ | |||
| <!-- card's title template --> | |||
| <ng-template #titleTemplate> | |||
| <ng-container *ngIf="this.cvcTitleTemplate"> | |||
There was a problem hiding this comment.
Out of curiosity, if you switch this from an *ngIf to the new @if, does it remove the need to assert that the template exists with !?
At least so far the new @ things seem to be smarter about types in my experience,.
There was a problem hiding this comment.
I gave it a try, but still get the TS error b/c cvcTitleTemplate's type is defined as Maybe<TemplateRef<void>>. We'd have to switch that to TemplateRef<void> to remove the ! assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues: