correctly use Variant as subject of AcceptRevisionsActivity

griffithlab · Oct 30, 2024 · 76042f9 · 76042f9
1 parent 509ccd1
commit 76042f9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/server/app/models/activities/accept_revisions.rb b/server/app/models/activities/accept_revisions.rb
@@ -10,8 +10,12 @@ def initialize(accepting_user:, revisions:, organization_id: nil, note:)
 
     private
     def create_activity
+      #Set the subject of this activity to the subject of the revision's creation activity
+      #In the case of gene/exon coordinates, the revision's subject will be the coordinate Object
+      #which we do not want. The creation activity's subject will be the Variant.
+      activity_subject = revisions.first&.creation_activity&.subject
       @activity = AcceptRevisionsActivity.create!(
-        subject: revisions.first.subject,
+        subject: activity_subject,
         user: accepting_user,
         organization: organization,
         note: note