fix net price for powerup and stake #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unicove ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying unicove with
|
| Latest commit: |
300b843
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b27b78c0.wallet-2tl.pages.dev |
| Branch Preview URL: | https://kurt-fix-netprice.wallet-2tl.pages.dev |
ttwishing
commented
Sep 13, 2024
src/pages/resources/resources.ts
Outdated
| [activeBlockchain, msToRent, sampleUsage], | ||
| ([$activeBlockchain, $msToRent, $sampleUsage]) => { | ||
| if ($msToRent && $sampleUsage) { | ||
| const {account} = $sampleUsage | ||
| const { account } = $sampleUsage | ||
| const cpu_weight = Number(account.total_resources.cpu_weight.units) | ||
| const cpu_limit = Number(account.cpu_limit.max.value) | ||
| let price = cpu_weight / cpu_limit | ||
| if ($activeBlockchain.resourceSampleMilliseconds) { |
There was a problem hiding this comment.
The resourceSampleMilliseconds of the telos chain is 1000, not sure if it has any impact
ttwishing
force-pushed
the
kurt-fix-netprice
branch
2 times, most recently
from
70ac369
to
313258b
Compare
ttwishing
force-pushed
the
kurt-fix-netprice
branch
from
313258b
to
f374336
Compare
dafuga
reviewed
Sep 21, 2024
dafuga
reviewed
Sep 21, 2024
src/pages/resources/resources.ts
Outdated
|
|
||
| const getResourceClient = (chain: ChainConfig) => { | ||
| const api = getClient(chain) | ||
| const options: any = {api} | ||
| const options: any = { api } |
There was a problem hiding this comment.
I know that we don't want to spend too much time on this project, but we could probably use a proper type here instead of any.
There was a problem hiding this comment.
ResourcesOptions it not exported. Otherwise, need to change greymass/eosio-resources，Can this be ignored?
dafuga
reviewed
Sep 21, 2024
dafuga
reviewed
Sep 21, 2024
dafuga
reviewed
Sep 21, 2024
dafuga
requested changes
Sep 21, 2024
|
It looks like CI checks are failing because of this error so we should also fix that: |
ttwishing
force-pushed
the
kurt-fix-netprice
branch
from
91a5c9b
to
931ed3c
Compare
ttwishing
force-pushed
the
kurt-fix-netprice
branch
2 times, most recently
from
ed1b51f
to
d47431f
Compare
ttwishing
force-pushed
the
kurt-fix-netprice
branch
from
d47431f
to
300b843
Compare
aaroncox
pushed a commit
that referenced
this pull request
Oct 2, 2024
* fix net price for powerup and stake * fix rex price for net rent * fix eos symbol to core token symbol * fix REXInfo import error * format resources.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add net powerup price、rex price、staking price
case1: powerup rent, 0.0001 EOS per kb
======Base
Available:102981.54 kb
Used:0.00 kb
Maximum:102981.54 kb
====After Rent 1000KB for 0.1000 EOS
Available: 103981.54 kb
Used: 0.00 kb
Maximum: 103981.54 kb
case2: rex rent, 0.00004 EOS per kb
======Base
Available: 103981.54 kb
Used:0.00 kb
Maximum:103981.54 kb
======After Rent 100KB for 0.0040 EOS
Available:106955.54 kb
Used:0.00 kb
Maximum:106955.54 kb
case3: staking rent, 0.0528 EOS per kb
======Base
Available:106955.54 kb
Used:0.00 kb
Maximum:106955.54 kb
======After: rent 0.0528 EOS
Available:106956.54 kb
Used:0.00 kb
Maximum:106956.54 kb
calculate stakingprice in kb or ms, avoid the situation where the asset value is 0 in smaller units