-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not preload hidden files and files in hidden folders #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelmay
requested changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not remove the mentioned foo-bar and drafts folders. These make the test fail.
Otherwise looks good, thanks alot!
greenmail-core/src/test/resources/preload/foo-bar@localhost/.keepme
Outdated
Show resolved
Hide resolved
greenmail-core/src/test/resources/preload/drafts@localhost/Drafts/.keepme
Outdated
Show resolved
Hide resolved
This was referenced May 31, 2024
Bump com.icegreen:greenmail from 2.1.0-alpha-4 to 2.1.0-rc-1
spring-projects/spring-integration#9200
Closed
Bump com.icegreen:greenmail from 2.1.0-alpha-4 to 2.1.0-rc-1
spring-projects/spring-integration#9203
Closed
Bump com.icegreen:greenmail from 2.1.0-alpha-4 to 2.1.0-rc-1
spring-projects/spring-integration#9205
Closed
This was referenced Oct 6, 2024
Merged
Bump com.icegreen:greenmail from 2.0.1 to 2.1.0
jesperancinha/jeorg-security-defense-test-drives#339
Merged
Open
This was referenced Oct 7, 2024
Merged
nicopico-dev
pushed a commit
to nicopico-dev/n2rss
that referenced
this pull request
Oct 10, 2024
Bumps `greenmail` from 2.0.1 to 2.1.0. Updates `com.icegreen:greenmail` from 2.0.1 to 2.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/greenmail-mail-test/greenmail/releases">com.icegreen:greenmail's releases</a>.</em></p> <blockquote> <h2>2.1.0</h2> <p>This is the latest <a href="https://github.com/greenmail-mail-test/greenmail/issues?q=is%3Aclosed+milestone%3A2.1.0">2.1.0</a> release of GreenMail 2.1 based on Jakarta Mail 2.1 / Jakarta EE 10</p> <ul> <li>Use <a href="https://repo1.maven.org/maven2/com/icegreen/greenmail/2.1.0/">Maven Central</a> GAV coordinates <code>com.icegreen:greenmail:2.1.0</code> or see <a href="https://greenmail-mail-test.github.io/greenmail/#download">download</a> instructions</li> </ul> <h2>What's Changed</h2> <ul> <li> <p>Features</p> <ul> <li>Activate mail.debug when verbose mode enabled <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/797">#797</a></li> <li>Support direct filtering of received mails by user- and message-predicate <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/798">#798</a></li> </ul> </li> <li> <p>Dependency updates</p> <ul> <li>Bump spring.version from 5.3.36 to 5.3.39 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/739">#739</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/768">#768</a></li> <li>Bump jetty.version from 11.0.21 to 11.0.24 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/750">#750</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/776">#776</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/786">#786</a></li> <li>Bump org.assertj:assertj-core from 3.26.0 to 3.26.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/751">#751</a></li> <li>Bump azul/zulu-openjdk from 11.0.23-jre to 11.0.24-jre (greenmail-standalone container) <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/758">#758</a></li> <li>Bump junit5.version from 5.10.2 to 5.11.1 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/749">#749</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/769">#769</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/792">#792</a></li> <li>Bump log4j2.version from 2.23.1 to 2.24.1 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/787">#787</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/794">#794</a></li> </ul> </li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-rc-1...release-2.1.0">https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-rc-1...release-2.1.0</a></p> <h2>release-2.1.0-rc-1</h2> <p>This is the latest <a href="https://github.com/greenmail-mail-test/greenmail/issues?q=is%3Aclosed+milestone%3A2.1.0-rc-1">2.1.0-rc-1</a> preview release of GreenMail 2.1 based on Jakarta Mail 2.1 / Jakarta EE 10</p> <ul> <li>Use <a href="https://repo1.maven.org/maven2/com/icegreen/greenmail/2.1.0-rc-1/">Maven Central</a> GAV coordinates <code>com.icegreen:greenmail:2.1.0-rc-1</code> or see <a href="https://greenmail-mail-test.github.io/greenmail/#download">download</a> instructions</li> </ul> <h2>What's Changed</h2> <ul> <li> <p>Breaking changes</p> <ul> <li>IMAP Content-Type differs POP3 and IMAP (conten-type is not upper-cased anymore) <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/706">#706</a></li> </ul> </li> <li> <p>Bugfixes</p> <ul> <li>Handle input stream body fetch edge case by <a href="https://github.com/abdulaziz1928"><code>@abdulaziz1928</code></a> in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/724">greenmail-mail-test/greenmail#724</a></li> <li>Do not preload hidden files and files in hidden folders <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/682">#682</a> by <a href="https://github.com/An1s9n"><code>@An1s9n</code></a> in htps://redirect.github.com/greenmail-mail-test/greenmail/pull/683</li> </ul> </li> <li> <p>Dependency updates</p> <ul> <li>Bump spring.version from 5.3.32 to 5.3.36 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/698">#698</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/707">#707</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/721">#721</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/723">#723</a></li> <li>Bump jetty.version from 11.0.19 to 11.0.21 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/677">#677</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/722">#722</a></li> <li>Bump docker base image azul/zulu-openjdk from 11.0.21-jre to 11.0.23-jre in /greenmail-docker/standalone <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/681">#681</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/710">#710</a></li> <li>Bump jakarta.mail:jakarta.mail-api from 2.1.2 to 2.1.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/693">#693</a></li> <li>Bump jakarta.activation:jakarta.activation-api from 2.1.2 to 2.1.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/691">#691</a></li> <li>Bump org.eclipse.angus:angus-activation from 2.0.1 to 2.0.2 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/692">#692</a></li> <li>Bump org.eclipse.angus:jakarta.mail from 2.0.2 to 2.0.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/694">#694</a></li> <li>Bump junit5.version from 5.10.1 to 5.10.2 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/679">#679</a></li> </ul> </li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/An1s9n"><code>@An1s9n</code></a> made their first contribution in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/683">greenmail-mail-test/greenmail#683</a></li> <li><a href="https://github.com/abdulaziz1928"><code>@abdulaziz1928</code></a> made their first contribution in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/724">greenmail-mail-test/greenmail#724</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-alpha-4...release-2.1.0-rc-1">https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-alpha-4...release-2.1.0-rc-1</a></p> <h2>2.1.0-alpha-4</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/edddcd9f38f5b26a6b0cf53443e609daf649b9ee"><code>edddcd9</code></a> [maven-release-plugin] prepare release release-2.1.0</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/ae8724c5e9fcb9a836051b38c524368d9784b24e"><code>ae8724c</code></a> Updating docs for 2.1.0 release</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/e0093394c7f130bb29990c159132d9eec7d121f2"><code>e009339</code></a> Support direct filtering of received mails by user- and message-predicate (fi...</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/0d9a2c0116627821f020574d248c76f47f59ca3a"><code>0d9a2c0</code></a> Clarified GMU.getReceivedMessagesForDomain usage for mails with multiple reci...</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/6f288b4dc964b8f2bed9cc8338ad23ed17fd3f8b"><code>6f288b4</code></a> Adding test for cc-user ( <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/765">#765</a> )</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/8456005183b324fa308023ac0a3e302082080f8f"><code>8456005</code></a> Minor code-cleanup and -format issues</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/a9448d3fbdfeee4f368c5edb7d6f1c1789ea1612"><code>a9448d3</code></a> Updating bootstrap for site to latest patch version 4.6.x</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/727ab894a994c685232d0912f92dbc036edb8020"><code>727ab89</code></a> Updating doc for build requirement and contributing</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/c54e1b514aaedd4ff3001990b3af467d6cf6ee6e"><code>c54e1b5</code></a> Activate mail.debug when verbose mode enabled (fixes <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/797">#797</a>)</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/558c9595b599aa5140d46167ea39d4de250d4d39"><code>558c959</code></a> Build(deps): Bump log4j2.version from 2.24.0 to 2.24.1</li> <li>Additional commits viewable in <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.0.1...release-2.1.0">compare view</a></li> </ul> </details> <br /> Updates `com.icegreen:greenmail-junit5` from 2.0.1 to 2.1.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/greenmail-mail-test/greenmail/releases">com.icegreen:greenmail-junit5's releases</a>.</em></p> <blockquote> <h2>2.1.0</h2> <p>This is the latest <a href="https://github.com/greenmail-mail-test/greenmail/issues?q=is%3Aclosed+milestone%3A2.1.0">2.1.0</a> release of GreenMail 2.1 based on Jakarta Mail 2.1 / Jakarta EE 10</p> <ul> <li>Use <a href="https://repo1.maven.org/maven2/com/icegreen/greenmail/2.1.0/">Maven Central</a> GAV coordinates <code>com.icegreen:greenmail:2.1.0</code> or see <a href="https://greenmail-mail-test.github.io/greenmail/#download">download</a> instructions</li> </ul> <h2>What's Changed</h2> <ul> <li> <p>Features</p> <ul> <li>Activate mail.debug when verbose mode enabled <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/797">#797</a></li> <li>Support direct filtering of received mails by user- and message-predicate <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/798">#798</a></li> </ul> </li> <li> <p>Dependency updates</p> <ul> <li>Bump spring.version from 5.3.36 to 5.3.39 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/739">#739</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/768">#768</a></li> <li>Bump jetty.version from 11.0.21 to 11.0.24 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/750">#750</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/776">#776</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/786">#786</a></li> <li>Bump org.assertj:assertj-core from 3.26.0 to 3.26.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/751">#751</a></li> <li>Bump azul/zulu-openjdk from 11.0.23-jre to 11.0.24-jre (greenmail-standalone container) <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/758">#758</a></li> <li>Bump junit5.version from 5.10.2 to 5.11.1 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/749">#749</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/769">#769</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/792">#792</a></li> <li>Bump log4j2.version from 2.23.1 to 2.24.1 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/787">#787</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/794">#794</a></li> </ul> </li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-rc-1...release-2.1.0">https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-rc-1...release-2.1.0</a></p> <h2>release-2.1.0-rc-1</h2> <p>This is the latest <a href="https://github.com/greenmail-mail-test/greenmail/issues?q=is%3Aclosed+milestone%3A2.1.0-rc-1">2.1.0-rc-1</a> preview release of GreenMail 2.1 based on Jakarta Mail 2.1 / Jakarta EE 10</p> <ul> <li>Use <a href="https://repo1.maven.org/maven2/com/icegreen/greenmail/2.1.0-rc-1/">Maven Central</a> GAV coordinates <code>com.icegreen:greenmail:2.1.0-rc-1</code> or see <a href="https://greenmail-mail-test.github.io/greenmail/#download">download</a> instructions</li> </ul> <h2>What's Changed</h2> <ul> <li> <p>Breaking changes</p> <ul> <li>IMAP Content-Type differs POP3 and IMAP (conten-type is not upper-cased anymore) <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/706">#706</a></li> </ul> </li> <li> <p>Bugfixes</p> <ul> <li>Handle input stream body fetch edge case by <a href="https://github.com/abdulaziz1928"><code>@abdulaziz1928</code></a> in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/724">greenmail-mail-test/greenmail#724</a></li> <li>Do not preload hidden files and files in hidden folders <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/682">#682</a> by <a href="https://github.com/An1s9n"><code>@An1s9n</code></a> in htps://redirect.github.com/greenmail-mail-test/greenmail/pull/683</li> </ul> </li> <li> <p>Dependency updates</p> <ul> <li>Bump spring.version from 5.3.32 to 5.3.36 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/698">#698</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/707">#707</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/721">#721</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/723">#723</a></li> <li>Bump jetty.version from 11.0.19 to 11.0.21 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/677">#677</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/722">#722</a></li> <li>Bump docker base image azul/zulu-openjdk from 11.0.21-jre to 11.0.23-jre in /greenmail-docker/standalone <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/681">#681</a>, <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/710">#710</a></li> <li>Bump jakarta.mail:jakarta.mail-api from 2.1.2 to 2.1.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/693">#693</a></li> <li>Bump jakarta.activation:jakarta.activation-api from 2.1.2 to 2.1.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/691">#691</a></li> <li>Bump org.eclipse.angus:angus-activation from 2.0.1 to 2.0.2 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/692">#692</a></li> <li>Bump org.eclipse.angus:jakarta.mail from 2.0.2 to 2.0.3 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/694">#694</a></li> <li>Bump junit5.version from 5.10.1 to 5.10.2 <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/679">#679</a></li> </ul> </li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/An1s9n"><code>@An1s9n</code></a> made their first contribution in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/683">greenmail-mail-test/greenmail#683</a></li> <li><a href="https://github.com/abdulaziz1928"><code>@abdulaziz1928</code></a> made their first contribution in <a href="https://redirect.github.com/greenmail-mail-test/greenmail/pull/724">greenmail-mail-test/greenmail#724</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-alpha-4...release-2.1.0-rc-1">https://github.com/greenmail-mail-test/greenmail/compare/release-2.1.0-alpha-4...release-2.1.0-rc-1</a></p> <h2>2.1.0-alpha-4</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/edddcd9f38f5b26a6b0cf53443e609daf649b9ee"><code>edddcd9</code></a> [maven-release-plugin] prepare release release-2.1.0</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/ae8724c5e9fcb9a836051b38c524368d9784b24e"><code>ae8724c</code></a> Updating docs for 2.1.0 release</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/e0093394c7f130bb29990c159132d9eec7d121f2"><code>e009339</code></a> Support direct filtering of received mails by user- and message-predicate (fi...</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/0d9a2c0116627821f020574d248c76f47f59ca3a"><code>0d9a2c0</code></a> Clarified GMU.getReceivedMessagesForDomain usage for mails with multiple reci...</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/6f288b4dc964b8f2bed9cc8338ad23ed17fd3f8b"><code>6f288b4</code></a> Adding test for cc-user ( <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/765">#765</a> )</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/8456005183b324fa308023ac0a3e302082080f8f"><code>8456005</code></a> Minor code-cleanup and -format issues</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/a9448d3fbdfeee4f368c5edb7d6f1c1789ea1612"><code>a9448d3</code></a> Updating bootstrap for site to latest patch version 4.6.x</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/727ab894a994c685232d0912f92dbc036edb8020"><code>727ab89</code></a> Updating doc for build requirement and contributing</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/c54e1b514aaedd4ff3001990b3af467d6cf6ee6e"><code>c54e1b5</code></a> Activate mail.debug when verbose mode enabled (fixes <a href="https://redirect.github.com/greenmail-mail-test/greenmail/issues/797">#797</a>)</li> <li><a href="https://github.com/greenmail-mail-test/greenmail/commit/558c9595b599aa5140d46167ea39d4de250d4d39"><code>558c959</code></a> Build(deps): Bump log4j2.version from 2.24.0 to 2.24.1</li> <li>Additional commits viewable in <a href="https://github.com/greenmail-mail-test/greenmail/compare/release-2.0.1...release-2.1.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 11, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #682