Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTRIB] Handle connection error during version check #10650

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[CONTRIB] Handle connection error during version check #10650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b3744
Add connection error handler to version check
stejin Nov 8, 2024
bbc1056
Correct grammar in error messages
stejin Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion great_expectations/data_context/_version_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def _get_latest_version_from_pypi(self) -> version.Version | None:
except requests.HTTPError as http_err:
logger.debug(f"An HTTP error occurred when trying to hit PyPI API: {http_err}")
except requests.Timeout as timeout_exc:
logger.debug(f"Failed to hit the PyPI API due a timeout error: {timeout_exc}")
logger.debug(f"Failed to hit the PyPI API due to a timeout error: {timeout_exc}")
except requests.ConnectionError as connection_err:
logger.debug(f"Failed to hit the PyPI API due to a connection error: {connection_err}")

if not response_json:
return None
Expand Down
Loading