-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Unify dasharray-based highway=* rendering #4771
base: master
Are you sure you want to change the base?
Conversation
Some comments:
|
@imagico Given that you have implemented this yet in your style, and it seems to work fine, could you make a PR? |
I am not sure we have consensus to get rid of the purple boundaries. Previous discussion on this was non-conclusive - see #3489. Also note that in the AC-Style i stopped rendering nature reserves. I have also been thinking of in addition also not rendering subnational boundaries any more. This would put a much clearer focus in the map on the verifiable geography. If there is consensus now to move anything that cuts this Gordian knot in terms of colors that would make the AC-style road color changes feasible i would gladly make a PR. |
[matching screenshots at Z16] More to provide food for discussion rather than proposing this as a solution, here's a take on unified dash patterns. This uses casing dash patterns to show This does involve a fair bit of lua wrangling to generate a proxy Overall the style reflects UK Ordnance Survey mapping, and so may not translate well to other places. Note the lack of purple admin boundaries! |
Without knowing exactly what the different line signatures in your example are meant to depict - a dashed casing is not going to work because we already use that for our tunnel rendering. |
Just to make this clear: Showing a mock-up of a design idea in a very specific context at a specific scale is not a demonstration that this is a workable approach in general. In any case this is the wrong place for such a suggestion. Exploring new design concepts to improve our rendering of roads would be valuable. But because of the large number of design variants, the very diverse geometric contexts this needs to work in and the need to maintain an intuitive level of consistency across the whole road system this is not an easy matter. |
Unify dasharray-based
highway=*
renderingCurrently, we have a couple of
highway=*
values for which we use a dasharray-based rendering: bridleway, cycleway, footway, path, track, steps. Steps is a special case.We have many different dasharry patterns which are difficult to distinguish. Furthermore, they do not represent the same secondary tags on different primary tags: on trank, it’s six different values for tracktype (one for each tracktype and “no value”), on bridleway it’s nothing, and on footway and cycleway, it’s three different values for surface (upaved, unpaved, no value). That’s highly confusing. Having so many pattern makes them difficult to distinguish.
We could try to unify the other dasharray-based renderings:
This would also simplify our code base. It would also be conforming to what we do yet on roads (paved/unpaved as secondary tag). This would make the map more readable.
The question is if a unified line width would work well-balanced when some colors like red (footway) or blue (cycleway) get more attention than brown (track).
Fixes #4322
Closes #4692 (mutually exclusive)
This isn’t a ready-made PR, but rather a sort of mock-up for discussion, if this approach could work.
Test rendering with links to the example places:
Before
After