[WIP] added closest area and line strategies for tooltip tracking #170
+258
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelsbadmans
changed the title
zefirka
reviewed
Oct 16, 2023
| series: AlignedData; | ||
| }; | ||
|
|
||
| export const findClosestLines = ({x, y, series}: FindClosestAreaOptions) => { |
There was a problem hiding this comment.
Can you add unit tests for this util, mostly to ensure valid calculation of closest area/line between two X coordinates?
| export const findClosestLines = ({x, y, series}: FindClosestAreaOptions) => { | ||
| const [timeline, ...areas] = series as number[][]; | ||
|
|
||
| let i1 = 0, |
There was a problem hiding this comment.
I believe you can find i1 and i2 with using uplot.cursor.idx or something. I think traversing whole timeline on each setCursor generally is a bad idea, because tooltip.tracking is function which can be called very frequently.
| const x1 = timeline[i1]; | ||
| const x2 = timeline[i2]; | ||
|
|
||
| areas |
There was a problem hiding this comment.
Let's try to reduce number of possible iterations. I understand that in most cases it doesn't do any issues, but I'd like to keep calculations as fast as possible.
I mean let's do it in single loop
feelsbadmans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.