feat: add content-list #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuberdysheva
force-pushed
the
yuberdysheva/add-content-items
branch
from
6c1239a
to
706baae
Compare
|
Preview is ready. |
yuberdysheva
force-pushed
the
yuberdysheva/add-content-items
branch
from
0fe3eb3
to
760ef6a
Compare
NikitaCG
requested changes
Aug 1, 2023
| const iconData = getMediaImage(iconThemed); | ||
|
|
||
| return ( | ||
| <div className={b('item')} key={title || text}> |
There was a problem hiding this comment.
if we dont have title or text we dont have key, and we'll have error with this example
contentList = [{icon: '...'}, {icon: '...'}], {icon: '...'}]]
There was a problem hiding this comment.
you can use import {v4 as uuidv4} from 'uuid'; for key
src/sub-blocks/Content/Content.tsx
Outdated
| @@ -72,6 +75,7 @@ const Content = (props: ContentBlockProps & ClassNameProps) => { | |||
| /> | |||
| </div> | |||
| )} | |||
| {contentList && <ContentList contentList={contentList} size={size} />} | |||
There was a problem hiding this comment.
maybe just check the length of the array and not even render the component if it's empty?
NikitaCG
previously approved these changes
Aug 1, 2023
gorgeousvlad
requested changes
Aug 1, 2023
src/sub-blocks/Content/Content.tsx
Outdated
| @@ -72,6 +75,7 @@ const Content = (props: ContentBlockProps & ClassNameProps) => { | |||
| /> | |||
| </div> | |||
| )} | |||
| {contentList?.length && <ContentList contentList={contentList} size={size} />} | |||
There was a problem hiding this comment.
if contentList is empty array, 0 will be rendered here
| @@ -21,6 +30,7 @@ const MediaContent = (props: MediaContentProps) => { | |||
| links={links} | |||
| theme="default" | |||
| buttons={allButtons} | |||
| contentList={contentList} | |||
| const b = block('content-list'); | ||
|
|
||
| interface ContentListProps { | ||
| contentList: ContentItemProps[]; |
gorgeousvlad
reviewed
Aug 1, 2023
src/sub-blocks/Content/Content.tsx
Outdated
| @@ -75,7 +75,7 @@ const Content = (props: ContentBlockProps & ClassNameProps) => { | |||
| /> | |||
| </div> | |||
| )} | |||
| {list?.length && <ContentList list={list} size={size} />} | |||
| {list?.length && Boolean(list.length) && <ContentList list={list} size={size} />} | |||
There was a problem hiding this comment.
list?.length ? <ContentList list={list} size={size} /> : null
gorgeousvlad
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content component size L and S: https://preview.gravity-ui.com/page-constructor/468/?path=/story/components-content--size
Content Layout Block: https://preview.gravity-ui.com/page-constructor/468/?path=/story/blocks-contentlayout--default
Media Block: https://preview.gravity-ui.com/page-constructor/468/?path=/story/blocks-media--default