Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AsideHeader): preventUserRemoving prop for menu item and callbacks for AsideHeader #314

Merged
merged 9 commits into from
Oct 8, 2024
Merged

feat(AsideHeader): preventUserRemoving prop for menu item and callbacks for AsideHeader #314

merged 9 commits into from
Oct 8, 2024

Conversation

jenshenJ
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

DarkGenius
DarkGenius requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@DarkGenius DarkGenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jenshenJ jenshenJ requested a review from kendoow as a code owner October 4, 2024 10:48
@jenshenJ jenshenJ merged commit e3b6da1 into main Oct 8, 2024
5 checks passed
@jenshenJ jenshenJ deleted the feat/add-calbacks-and-prevent-user-removing-prop branch October 8, 2024 20:54
@gravity-ui-bot gravity-ui-bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkGenius DarkGenius DarkGenius approved these changes

@Lunory Lunory Awaiting requested review from Lunory Lunory is a code owner

@sunduckcow sunduckcow Awaiting requested review from sunduckcow sunduckcow is a code owner

@kendoow kendoow Awaiting requested review from kendoow kendoow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenshenJ @gravity-ui-bot @DarkGenius