Skip to content
CI

feat(AsideHeader): add onAllPagesClick callback #917

Sign in to view logs

feat(AsideHeader): add onAllPagesClick callback

feat(AsideHeader): add onAllPagesClick callback #917

Triggered via pull request October 24, 2024 09:52
@jenshenJjenshenJ
opened #329
feat/all-pages-click-callback
Status Success
Total duration 47s
Artifacts –

ci.yml

on: pull_request
Verify Files
36s
Verify Files
Tests
23s
Tests
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Verify Files
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Verify Files
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Verify Files: src/components/AllPagesPanel/useGroupedMenuItems.ts#L26
Assignment to property of function parameter 'acc'
Verify Files: src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx#L75
Expected return with your callback function
Verify Files: src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx#L166
'compact' is already declared in the upper scope on line 62 column 12
Verify Files: src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx#L298
Unexpected console statement
Verify Files: src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx#L299
Unexpected console statement
Verify Files: src/components/AsideHeader/useAsideHeaderInnerContextValue.tsx#L66
React Hook useMemo has a missing dependency: 'onAllPagesClick'. Either include it or remove the dependency array
Verify Files: src/components/CompositeBar/HighlightedItem/HighlightedItem.tsx#L42
'top' is already declared in the upper scope on line 29 column 13
Verify Files: src/components/CompositeBar/HighlightedItem/HighlightedItem.tsx#L43
'left' is already declared in the upper scope on line 29 column 18
Verify Files: src/components/CompositeBar/HighlightedItem/HighlightedItem.tsx#L44
'width' is already declared in the upper scope on line 29 column 24
Verify Files: src/components/CompositeBar/HighlightedItem/HighlightedItem.tsx#L45
'height' is already declared in the upper scope on line 29 column 31