Allow for parse to return a Promise #4278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
async-parse
branch
2 times, most recently
from
d0349a4
to
368d5a1
Compare
JoviDeCroock
commented
Nov 1, 2024
| ): DocumentNode { | ||
| const result = parse(source, options); | ||
| /* c8 ignore next 3 */ | ||
| if (isPromise(result)) { |
There was a problem hiding this comment.
As we can't really test this I've opted to ignore the lines, it's more so that consumers will be prepared to handle a Promise
JoviDeCroock
added
PR: breaking change 💥
|
I do not feel comfortable changing the type signature of I've raised #4285 as a separate feature that I think has independent value (allowing for optional simple user-provided caches) that change the type signature because the return value may be async. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to return a Promise from parsing, this is mainly intended so GraphQL servers are prepared for middleware approaches that can inject async caches.
I've opted to not do validate as this could create the impression that rules can run in the background, while all rules logic is synchronous.
I've also opted to not do the
parseValueand other parse equivalents as these seem less relevant for the caching bit.😅 still have to fix a lot of types but first gauging the appeal of this.
Resolves #3421