Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebase PeerDAS onto electra #55

Draft
wants to merge 62 commits into
base: develop
Choose a base branch
from
Draft

rebase PeerDAS onto electra #55

wants to merge 62 commits into from

Conversation

hangleang
Copy link
Contributor

this pull request will rebase the functionality of PeerDAS onto electra fork, this final update should express the current status of the implementation. this will be ready for review once these following PRs in other parts of the codebase merged into the upstream branch, then I will link the submodules to those commits:

Mdominykas and others added 30 commits November 10, 2024 12:10
@hangleang
implemented get_custody_columns
4d23b2f
@hangleang
wip
aa2d63a
@hangleang
implemented compute_extended_matrix
d4d5c15
@hangleang
wip
ceb2324
@hangleang
implemented recover_matrix
cf03ace
@hangleang
implemented get_data_column_sidecars
a22f211
@hangleang
moved c-kzg to dependencies
a5107da
@hangleang
further validation
9bb54b0
@hangleang
moved data sidecar verification to fork_choice_store
55561b4
@hangleang
data sidecar verifcation
77a00b1
@hangleang
fixed bug
67b9692
@hangleang
added tests. They fail, but in a same way as lighthouse
44aa08e
@hangleang
added part of networking
d8b3cae
@Tumas @hangleang
make it compile
a25e7a8
@Tumas @hangleang
use consensus spec tests latest versions
6de80a2
@Tumas @hangleang
WIP: move eip7594 types to types crate, add ssz_static tests for cont…
2f9cc27 
…ainers
@Tumas @hangleang
Adjust types, make tests pass for DataColumnSidecar container
32c57e1
@Tumas @hangleang
Add empty kzg_commitment_inclusion_proof and consensus tests for it
eef0580
@Tumas @hangleang
Use SubnetId for DataColumnSidecar subnets
e8b69ba
@weekday-grandine-io @hangleang
Fix inclusion proof construction in EIP-7594
602e7fb 
WARNING: EIP-7594 contains a new preset variable with a name nearly identical to an older one.
Compare:
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH  added in Deneb.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH added in EIP-7594.

Also note that neither variable is independent.
KZG_COMMITMENT_INCLUSION_PROOF_DEPTH is derived from MAX_BLOB_COMMITMENTS_PER_BLOCK.
KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH is effectively a constant.
@Tumas @hangleang
Rebase eth2_libp2p
8d84672
@Tumas @hangleang
Update grandine-snapshot-tests to include EIP7594_FORK_EPOCH in Config
6138bd4
@Tumas @hangleang
Move DATA_COLUMN_SIDECAR_SUBNET_COUNT const to types
38aa575
@povi @hangleang
Check if block has more than 50% of data columns to accept it as valid
d06200a
@Tumas @hangleang
update eth2_libp2p
e68911d
@hangleang
Validate pending block against it's parent's data availability
92812d6
@Tumas @hangleang
WIP: Add DataColumnsByRoot rpc
cb43bd3
@Tumas @hangleang
Handle DataColumnSidecars received from RPC by root
20be39b
@Tumas @hangleang
Request needed data columns from mutator
6ba40b1
@Tumas @hangleang
remove todo! macros in network
4a1b384
povi and others added 27 commits November 10, 2024 12:15
@povi @hangleang
Include trusted setup bytes into binary for use in eip_7594 module
33c9b08
@Tumas @hangleang
Make get_custody_columns tests pass
bab72a8
@Tumas @hangleang
Remove unused constants & add more debug info about DataColumnSidecar
4c3f3c6
@povi @hangleang
Remove unused eip_7594 methods
6925d14
@Tumas @hangleang
Add error from verify_kzg_proofs to store Error
37a6f03
@povi @hangleang
Use correct blob KZG commitments generalized index when verifying dat…
c7f89b8 
…a column sidecar's inclusion proof
@Tumas @hangleang
Handle DataColumnsByRange request
d5a45d1
@povi @hangleang
Fix eip_7594::verify_kzg_proofs
5a268d8
@Tumas @hangleang
Improve kzg_proofs conversions in get_data_column_sidecars
57d2946
@povi @hangleang
Various fixes
700f1e5
@Tumas @hangleang
Relax parent availablity check
4c7e4ec
@povi @hangleang
Data column cache pruning
81e1e90
@Tumas @hangleang
fix get_data_column_sidecars & improve code formatting
68d397c
@povi @hangleang
Delay data column sidecars and retry processing them when conditions …
325af2d 
…allow
@Tumas @hangleang
Validate DataColumnSidecar subnet if it is present
8218b9b
@povi @hangleang
Update constants
09c851a
@Tumas @hangleang
Stub data column sidecar syncing
0715c13
@Tumas @hangleang
Use is_forward_synced for stub instead of initial_forward_sync
962f80b
@Tumas @hangleang
Use hardcoded DATA_COLUMN_SIDECAR_COUNT (32) for now
d5d3411
@Tumas @hangleang
Don't request blobs when das enabled
add4f2f
@Tumas @hangleang
apply stubbed availablity check for parent
7c3cf9e
@Tumas @hangleang
subscribe to all subnets by default
6d960a7
@Tumas @hangleang
WIP: DataColumnsByRange RPC
6bba545
@povi @hangleang
Data column cache
b377e18
@povi @hangleang
WIP: config
cc9a970
@hangleang
rebase feature/das onto develop branch
e78ecf8
@hangleang
fix: rebase conflicts, reconstruction runtime error
31b3e37 
fix(wip): resolved conflicts after rebase

fix(wip): resolved code conflicted

fix: failed kzg_commitment_inclusion_proof tests and remove usued imports

fix: subscribe data column subnets if eip7594 scheduled

fix: kzg_inclusion_proofs in deneb and electra

fix: validate block with DA checking

update snapshot-tests, eth2_libp2p

fix: missing check in spec test

chore: sort custody subnets

fix: reconstruction runtime error
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ Tumas
✅ hangleang
❌ povi
❌ weekday-grandine-io
You have signed the CLA already but the status is still pending? Let us recheck it.

@hangleang hangleang marked this pull request as draft November 10, 2024 06:44
@hangleang hangleang mentioned this pull request Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hangleang @CLAassistant @Tumas @weekday-grandine-io @povi