Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger publish images when release happens #696

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

rubenvp8510
Copy link
Collaborator

It seems that even if creating a release creates a tag, The publish image was not triggered. it seems like you need to explicitly push the tag to trigger it.

In this PR I also add the release published event (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release) in order to trigger this workflow with the new approach.

I had to run manually for this release in order to have the image published.

@andreasgerstmayr please review.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f6c91d) 78.22% compared to head (a6ede9f) 78.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          66       66           
  Lines        5023     5023           
=======================================
  Hits         3929     3929           
  Misses        907      907           
  Partials      187      187           
Flag Coverage Δ
unittests 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasgerstmayr
Copy link
Collaborator

Nice catch! That's odd that the release workflow doesn't get triggered, as this tag is still getting created/pushed when doing the release with the gh release create command.

@andreasgerstmayr andreasgerstmayr merged commit f1cb190 into grafana:main Nov 22, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants