Change default route to reencrypt for gateway #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 106 106
Lines 6624 6624
=======================================
Hits 4841 4841
Misses 1493 1493
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frzifus
reviewed
Sep 6, 2024
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
reencrypt_gw_default
branch
from
f9bba38
to
d6e429f
Compare
frzifus
approved these changes
Sep 7, 2024
| @@ -0,0 +1,16 @@ | |||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | |||
| change_type: enhancement | |||
There was a problem hiding this comment.
Is it maybe breaking? Since some certs will change.
There was a problem hiding this comment.
I don't think this is a breaking change, as the other things will remaing working in the same way. I think this only adds a couple of hosts to the cert.
|
Ahh, monolithic-receivers-tls failed |
Flaky test |
andreasgerstmayr
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.