Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update updater #3629

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: update updater #3629

merged 1 commit into from
Oct 15, 2024

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Oct 15, 2024 •
edited
Loading

CI pipeline fails on main due to:

GOBIN=/home/runner/work/pyroscope/pyroscope/.tmp/bin GOPRIVATE=github.com/grafana/deployment_tools go install github.com/grafana/deployment_tools/drone/plugins/cmd/updater@d64d509
go: downloading github.com/grafana/deployment_tools/drone/plugins v0.0.0-20220712102523-d64d5092c42b
go: downloading github.com/grafana/deployment_tools v0.0.0-20220712102523-d64d5092c42b
go: github.com/grafana/deployment_tools/drone/plugins/cmd/updater@d64d509: loading deprecation for github.com/grafana/deployment_tools/drone/plugins: no matching versions for query "latest"
make: *** [Makefile:353: /home/runner/work/pyroscope/pyroscope/.tmp/bin/updater] Error 1

I'm not entirely sure what caused this (it may be modcache, or expired token), but it looks like we haven't been updating the tool for a while. Since then it changed its package path. I hope updating it will resolve the problem, although I can't reproduce it locally

@kolesnikovae kolesnikovae requested a review from a team as a code owner October 15, 2024 09:12
@kolesnikovae kolesnikovae enabled auto-merge (squash) October 15, 2024 09:22
korniltsev
korniltsev approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@kolesnikovae kolesnikovae merged commit 596641b into main Oct 15, 2024
18 checks passed
@kolesnikovae kolesnikovae deleted the chore/update-updater branch October 15, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @korniltsev