Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup frontend dependencies, remove storybook #3591

Merged
merged 3 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ testSetupFile.js
og/**
examples/**
public/app/util/**
public/app/stories/**
**.spec.ts*
svg-transform.js
setupAfterEnv.ts
Expand Down
1 change: 0 additions & 1 deletion og/.eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
scripts/**
dist
.eslintrc.js
stories
setupAfterEnv.ts
jest.config.js
cypress
1 change: 0 additions & 1 deletion og/.eslintrc.js.notactive
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ module.exports = {
'**/*.spec.jsx',
'**/*.spec.ts',
'**/*.spec.tsx',
'**/*.stories.tsx',
],
packageDir: [
// TODO compute this dynamically
Expand Down
17 changes: 3 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
"lint:fix": "yarn lint --fix",
"format": "prettier --check .",
"format:fix": "prettier --write .",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
"prepare:manually": "husky install"
},
"lint-staged": {
Expand All @@ -31,19 +29,12 @@
"@grafana/eslint-config": "^6.0.0",
"@size-limit/file": "^6.0.3",
"@size-limit/time": "^6.0.3",
"@storybook/addon-actions": "~6.5.0",
"@storybook/addon-essentials": "~6.5.0",
"@storybook/addon-links": "~6.5.0",
"@storybook/builder-webpack5": "~6.5.0",
"@storybook/manager-webpack5": "~6.5.0",
"@storybook/react": "~6.5.0",
"@swc/core": "^1.3.74",
"@swc/jest": "^0.2.27",
"@testing-library/cypress": "^9.0.0",
"@testing-library/dom": "^9.3.1",
"@testing-library/jest-dom": "^5.17.0",
"@testing-library/react": "^14.0.0",
"@testing-library/react-hooks": "^8.0.1",
"@testing-library/user-event": "^13.2.1",
"@types/color": "^3.0.2",
"@types/d3-scale": "^4.0.2",
Expand Down Expand Up @@ -75,7 +66,6 @@
"conventional-changelog-cli": "^2.1.1",
"copy-webpack-plugin": "^11.0.0",
"cypress": "^12.11.0",
"cypress-image-snapshot": "^4.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is in the og folder which in my understanding is mostly there for reference but it is unused and has its own package.json.

"esbuild-loader": "^3.0.1",
"eslint": "^8.40.0",
"eslint-config-airbnb": "18.2.1",
Expand All @@ -96,11 +86,12 @@
"expose-loader": "^4.1.0",
"html-webpack-plugin": "^5.5.0",
"husky": "^8.0.3",
"jest": "^27.5.1",
"jest": "^28.1.3",
"jest-canvas-mock": "^2.3.1",
"jest-css-modules-transform": "^4.4.2",
"jest-environment-jsdom": "^27.5.1",
"jest-environment-jsdom": "^28.1.3",
"jest-fetch-mock": "^3.0.3",
"jest-image-snapshot": "^5.2.0",
"lint-staged": "^15.0.2",
"mini-css-extract-plugin": "^2.7.5",
"msw": "^0.36.3",
Expand All @@ -117,7 +108,6 @@
"typescript-plugin-css-modules": "^3.4.0",
"web-streams-polyfill": "^3.2.1",
"webpack": "^5.94.0",
"webpack-bundle-analyzer": "^4.4.2",
"webpack-cli": "^5.0.1",
"webpack-dev-server": "^4.13.1",
"webpack-livereload-plugin": "^3.0.2",
Expand All @@ -135,7 +125,6 @@
"@hookform/resolvers": "^2.9.8",
"@mui/base": "5.0.0-alpha.98",
"@mui/material": "5.10.11",
"@mui/types": "7.2.0",
"@react-hook/resize-observer": "^1.2.6",
"@react-hook/window-size": "^3.1.1",
"@reduxjs/toolkit": "^1.6.2",
Expand Down
68 changes: 0 additions & 68 deletions public/app/.storybook/main.js

This file was deleted.

9 changes: 0 additions & 9 deletions public/app/.storybook/preview.js

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { RefObject } from 'react';
import { renderHook } from '@testing-library/react-hooks';
import { renderHook } from '@testing-library/react';
import { Provider } from 'react-redux';
import { configureStore } from '@reduxjs/toolkit';
import { continuousReducer } from '@pyroscope/redux/reducers/continuous';
Expand Down
38 changes: 0 additions & 38 deletions public/app/stories/Box.stories.tsx

This file was deleted.

39 changes: 0 additions & 39 deletions public/app/stories/Button.stories.tsx

This file was deleted.

70 changes: 0 additions & 70 deletions public/app/stories/Dialog.stories.tsx

This file was deleted.

60 changes: 0 additions & 60 deletions public/app/stories/Dropdown.stories.tsx

This file was deleted.

Loading
Loading