Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix nth-check version & d3-color #2009

Merged
merged 5 commits into from
Jul 19, 2023
Merged

chore: fix nth-check version & d3-color #2009

merged 5 commits into from
Jul 19, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 998.83 KB (+0.01% 🔺) 20 s (+0.01% 🔺) 4.6 s (+2.29% 🔺) 24.6 s
webapp/public/assets/app.css 19.9 KB (0%) 399 ms (0%) 0 ms (+100% 🔺) 399 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 625.81 KB (+0.01% 🔺) 12.6 s (+0.01% 🔺) 2.2 s (+8.85% 🔺) 14.7 s
packages/pyroscope-flamegraph/dist/index.node.js 626.56 KB (+0.02% 🔺) 12.6 s (+0.02% 🔺) 778 ms (-15.12% 🔽) 13.4 s
packages/pyroscope-flamegraph/dist/index.css 8.14 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@darrenjaneczek darrenjaneczek marked this pull request as ready for review July 18, 2023 13:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #2009 (e0bf410) into main (e0bf410) will not change coverage.
The diff coverage is n/a.

❗ Current head e0bf410 differs from pull request most recent head 467720f. Consider uploading reports for the commit 467720f to get more accurate results

@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files         177      177           
  Lines        4999     4999           
  Branches     1158     1158           
=======================================
  Hits         3021     3021           
  Misses       1966     1966           
  Partials       12       12

@darrenjaneczek darrenjaneczek changed the title chore: fix nth-check version chore: fix nth-check version & d3-color Jul 18, 2023
cyriltovena
cyriltovena approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit f438451 into main Jul 19, 2023
20 checks passed
@cyriltovena cyriltovena deleted the chore/dependency-fix-nth-check branch July 19, 2023 06:15
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
chore: fix nth-check version & d3-color (grafana#2009)
bc176ce 
* chore: fix nth-check version

* fix: also include resolution for d3-color

* fix: yarn lock spacing
simonswine pushed a commit that referenced this pull request Jul 20, 2023
@darrenjaneczek @simonswine
chore: fix nth-check version & d3-color (#2009)
643f3be 
* chore: fix nth-check version

* fix: also include resolution for d3-color

* fix: yarn lock spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@abannachGrafana abannachGrafana abannachGrafana approved these changes

@petethepig petethepig Awaiting requested review from petethepig

@Rperry2174 Rperry2174 Awaiting requested review from Rperry2174

Assignees
No one assigned
Labels
has conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darrenjaneczek @codecov-commenter @cyriltovena @abannachGrafana