Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update presets on time picker #1999

Closed
Rperry2174 opened this issue Jul 14, 2023 · 3 comments
Closed

Update presets on time picker #1999

Rperry2174 opened this issue Jul 14, 2023 · 3 comments
Assignees
@darrenjaneczek
Labels
frontend Mostly JS code

Comments

@Rperry2174
Copy link
Contributor

The initial time picker had a bunch of defaults that we copied from Grafana's old time picker. In reality, it is definitely not recommended for people to query, for example, 5 years of profiling data.
image

We should update the date picker to look / function similar to the new grafana date picker except limit the presets to no longer than 6 months (maybe even shorter)
image
@Rperry2174 Rperry2174 added the frontend Mostly JS code label Jul 14, 2023
@darrenjaneczek darrenjaneczek self-assigned this Jul 17, 2023
@darrenjaneczek darrenjaneczek mentioned this issue Jul 17, 2023
Merged
@darrenjaneczek
Copy link
Collaborator

I am considering that in a pyroscope environment, the current picker can be used.
When in a Grafana environment, the Grafana picker can be used instead.

@eh-am
Copy link
Collaborator

eh-am commented Jul 18, 2023

My understanding that pyroscope frontend can mostly be replaced by grafana components, including the datepicker.

@darrenjaneczek
Copy link
Collaborator

@Rperry2174 , are we satisfied by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darrenjaneczek darrenjaneczek

Labels
frontend Mostly JS code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eh-am @Rperry2174 @darrenjaneczek