-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit time picker presets #2008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 177 177
Lines 4999 4999
Branches 1158 1158
=======================================
Hits 3021 3021
Misses 1966 1966
Partials 12 12 |
Flamegraph.com reportCreated by Flamegraph.com Github Action |
size-limit report 📦
|
Flamegraph.com reportCreated by Flamegraph.com Github Action |
@cyriltovena whats the longest preset we should support here? I would say lets go one more and make the max preset 30 days |
darrenjaneczek
force-pushed
the
fix/time-picker-presets
branch
from
July 19, 2023 19:25
eacb84a
to
7f9c913
Compare
simonswine
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with leaving the 90 days for now
LGTM
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 20, 2023
simonswine
pushed a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new maximum time range preset if 90 days.