Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mixin): Update dashboards for bloom components #14529

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(mixin): Update dashboards for bloom components #14529

wants to merge 4 commits into from
+12,848 −6,587

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Oct 18, 2024

What this PR does / why we need it:

  • Update bloom gateway dashboard
  • Replace bloom compactor with bloom build dashboard

Special notes for your reviewer:

Followed the instructions

// !--- HOW TO UPDATE THIS DASHBOARD ---!
// 1. Export the dashboard from Grafana as JSON
//    !NOTE: Make sure you collapse all rows but the (first) Overview row.
// 2. Copy the JSON into `dashboard-bloom-xxx.json`
// 3. Delete the `id` and `templating` fields from the JSON

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum changed the title chor(blooms): Update dashboards for bloom components chore(blooms): Update dashboards for bloom components Oct 18, 2024
@chaudum chaudum changed the title chore(blooms): Update dashboards for bloom components chore(mixin): Update dashboards for bloom components Oct 18, 2024
@chaudum chaudum marked this pull request as ready for review October 18, 2024 12:05
@chaudum chaudum requested a review from a team as a code owner October 18, 2024 12:05
@chaudum chaudum force-pushed the chaudum/bloomfilter-mixin branch 4 times, most recently from 71df367 to d869c5c Compare October 18, 2024 14:52
rfratto
rfratto approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few minor issues in the dashboards but otherwise LGTM. I only left my comments on the compiled-ssd mixin, but I think what I found probably applies to all copies of them.

production/loki-mixin-compiled-ssd/dashboards/loki-bloom-build.json
"showLineNumbers": false,
"showMiniMap": false
},
"content": "Identify the tenant using the **_Progress by tenant_** panel from the overview and set tenant variable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tenant variable so the panels in this row are always blank

production/loki-mixin-compiled-ssd/dashboards/loki-bloom-gateway.json
{
"datasource": {
"type": "loki",
"uid": "${logs}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${logs} doesn't exist as a variable, so this panel fails to load (ditto with the Errors Rate panel)

production/loki-mixin-compiled-ssd/dashboards/loki-bloom-gateway.json
"refId": "B"
}
],
"title": "Filtered series",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This panel was blank for me, while "Found/Skipped/Missing series" wasn't. Bug?

production/loki-mixin-compiled-ssd/dashboards/loki-bloom-gateway.json
}
],
"title": "Disk writes",
"title": "Disk reads/writes",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a 12h time range, this fails with

execution: query processing would load too many samples into memory in query execution

It works with a 1h time range though. Should we change the query to load less samples?

production/loki-mixin-compiled-ssd/dashboards/loki-bloom-gateway.json
"range": true,
"refId": "B"
}
],
"title": "Block download queue",
"type": "timeseries"
"title": "Dequeue count",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This panel is blank for me even though "Dequeue duration" isn't blank. Bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @rfratto