Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logcli): create new tail response for every line #14525

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented Oct 18, 2024

What this PR does / why we need it:
When tailing with logcli, the loghttp.TailResponse is created outside of the loop, resulting in stale labels within the TailResponse LabelSet as the unmarshal does not clear the map.

Which issue(s) this PR fixes:
Fixes #8617

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

When tailing with logcli, the loghttp.TailResponse is created outside of
the loop, resulting in stale labels within the TailResponse LabelSet as
the unmarshal does not clear the map.

Fixes grafana#8617

Signed-off-by: Cyrill Troxler <[email protected]>
@ctrox ctrox requested a review from a team as a code owner October 18, 2024 06:31
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chaudum chaudum merged commit bcfd0d1 into grafana:main Oct 18, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[logcli] tailing queries mixes wrong labels in
3 participants