Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logql): A renamed label should use ParsedLabel category to take precendence (backport k224) #14516

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Oct 17, 2024

Backport 82fb2f0 from #14515


What this PR does / why we need it:

Renaming labels using label_format dst=src is broken on main. Destination label does not appear in the resulting label set if the source is a stream label. This is because we don't append the labels from add[StreamLabel] list to the resulting buffer, this looks like a conscious choice to not pollute StreamLabels.

I felt the correct fix here is to correctly tag the renamed label as a ParsedLabel. This also makes sure the new label supersedes any structured metadata if present.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner October 17, 2024 11:35
@loki-gh-app loki-gh-app bot added backport size/S type/bug Somehing is not working as expected labels Oct 17, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 25bee22 into k224 Oct 17, 2024
66 checks passed
@ashwanthgoli ashwanthgoli deleted the backport-14515-to-k224 branch October 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant