Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: speciy golangci-lint build tags at runtime #14456

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

This allows golangci-lint to be run natively on MacOS, which allows it to be integrated into many editors via something like https://github.com/nametake/golangci-lint-langserver.

According to golangci-lint docs

Slice options (e.g. list of enabled/disabled linters) are combined from the command-line and config file.

This means non-linux users have no way of removing the linux and promtail_journal_enabled build tags if they are specified in .golangci.yml. By removing them from there and instead specifying the additional tags needed for linux at runtime (which is done via the Makefile change in this PR), it allows users on all platforms to benefit from the linting in real time.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney merged commit b8f17ab into main Oct 10, 2024
62 checks passed
@trevorwhitney trevorwhitney deleted the golangci-lint-build-tags-at-runtime branch October 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants