chore(operator): Update build and runtime deps #14416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
requested review from
xperimental,
JoaoBraveCoding and
a team
as code owners
periklis
force-pushed
the
k8s-bump-1.30
branch
from
2401693
to
ae5db7f
Compare
periklis
force-pushed
the
k8s-bump-1.30
branch
from
388c113
to
318fcb5
Compare
xperimental
reviewed
Oct 8, 2024
xperimental
approved these changes
Oct 9, 2024
| @@ -1,7 +1,7 @@ | |||
| module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT | |||
|
|
|||
| go 1.21 | |||
| go 1.22.1 | |||
There was a problem hiding this comment.
Did bingo produce this? Usually this line is just major.minor and not the complete version ...
I noticed later that there's go 1.22.0 on the operator/go.mod and now I'm even more confused.
| @@ -178,7 +178,7 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
| } else { | |||
| fmt.Fprintf(os.Stdout, "---\n%s", b) | |||
| _, _ = fmt.Fprintf(os.Stdout, "---\n%s", b) | |||
There was a problem hiding this comment.
Should we put a "ignore this line in lint" comment on this instead of the _, _ =?
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 9, 2024
6 tasks
trevorwhitney
pushed a commit
that referenced
this pull request
Oct 10, 2024
This was referenced Oct 11, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 11, 2024
[release-6.0] Backport PR grafana#14416
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 14, 2024
[release-5.6] Partial backport PR grafana#14416
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 14, 2024
[release-5.9] Partial backport PR grafana#14416
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 14, 2024
[release-5.8] Partial backport PR grafana#14416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Regular upgrade cycle before releasing the next Community Loki Operator version:
v1.21v1.22.81.28.7v1.30.5v0.16.5v0.18.50.71.2v0.76.1v1.19.0v1.20.4v1.33.0v1.33.0v1.56.2v1.61.0v0.6.0v0.7.0v0.22.0v0.22.0Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR