fix: promtail config unmarshalling #14408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in all default values being missing Signed-off-by: Callum Styan <[email protected]>
trevorwhitney
approved these changes
Oct 7, 2024
trevorwhitney
changed the title
7 tasks
trevorwhitney
added a commit
that referenced
this pull request
Oct 10, 2024
Squashed commit of the following: commit 4ea549a Author: Trevor Whitney <[email protected]> Date: Tue Oct 8 13:18:35 2024 -0600 chore: fix tests, add more requestion validation commit 55b0aa1 Author: Trevor Whitney <[email protected]> Date: Mon Oct 7 14:28:21 2024 -0600 chore: lint and format commit c78c5fa Author: Trevor Whitney <[email protected]> Date: Mon Oct 7 14:03:26 2024 -0600 feat: add range support to agg metric volume queries commit 93cc007 Author: Trevor Whitney <[email protected]> Date: Wed Oct 2 16:29:08 2024 -0600 feat: aggregated metric volume queries commit 1f30892 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Oct 7 13:43:34 2024 -0400 chore(deps): update dependency fluent-plugin-multi-format-parser to '~>1.1.0' (#14396) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit a05431f Author: Callum Styan <[email protected]> Date: Mon Oct 7 10:01:28 2024 -0700 fix: promtail config unmarshalling (#14408) Signed-off-by: Callum Styan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug introduced in #13719 that caused unmarshaling to use an empty struct, which resulted in all default values being missing, supersedes #14259